Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json marshaling tests for action usage and OIDC types #2944

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Add json marshaling tests for action usage and OIDC types #2944

merged 1 commit into from
Oct 1, 2023

Conversation

rameshgkwd05
Copy link
Contributor

This PR covers JSON marshalling testing for following types (partial fix for #55)

  1. actions_oidc

    1. type OIDCSubjectClaimCustomTemplate

  2. actions_cache

    1. type ActionsCache
    2. type ActionsCacheList
    3. type ActionsCacheUsage
    4. type ActionsCacheUsageList
    5. type TotalCacheUsage
    6. (type ActionsCacheListOptions does not have any json encoding so we have skipped test case for it.)

NOTE for reviewers: This contribution is for hactoberfest credit please label it so. Thanks!

@rameshgkwd05
Copy link
Contributor Author

Newly added tests are running fine locally
Screenshot 2023-10-01 at 10 06 58 PM

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #2944 (fc3e7b5) into master (d99d3df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2944   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         145      145           
  Lines       12720    12720           
=======================================
  Hits        12490    12490           
  Misses        156      156           
  Partials       74       74

@gmlewis gmlewis changed the title Add json marshalling tests for action usage and OIDC types Add json marshaling tests for action usage and OIDC types Oct 1, 2023
gmlewis
gmlewis approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rameshgkwd05 !
LGTM.
Merging.

@gmlewis gmlewis merged commit 8cd452b into google:master Oct 1, 2023
7 checks passed
@gmlewis gmlewis mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rameshgkwd05 @gmlewis